Re: MS-Windows build of Grep [2/4]

[Jim Meyering]

Eli Zaretskii wrote:
>> From: Jim Meyering <address@hidden>
>> Cc: address@hidden,  address@hidden,  address@hidden
>> Date: Fri, 30 Dec 2011 12:28:40 +0100
>>
>> > Bottom line: just add a test against zero inodes to SAME_INODE, and be
>> > done.  You can then remove the test in main.c for that, as a bonus.
>>
>> As explained at length, I prefer not to change the semantics of SAME_INODE.
>
> Sorry, I don't understand: SAME_INODE will still return a boolean.
> That was the only change I understood you objected to.
>
> And the semantics will be the same; an inode of zero is never "equal"
> to another inode.
>
> What did I miss?

This is about changing code that everyone uses, in order to
make it accommodate a system that is so fundamentally deficient
that imho it is not a reasonable portability target.

As long as its *stat functions (or wrappers) do not provide usable
stat.st_ino, trying to accommodate such systems is a waste of time.