bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

STREQ in dfa.c


From: arnold
Subject: STREQ in dfa.c
Date: Sat, 31 Dec 2011 09:38:14 -0800

Hi Jim et al.

> It's a little annoying that STREQ is already defined in two places
> (we prefer to keep dfa.c self-contained, to accommodate gawk):
>
>     $ git grep fine.STREQ
>     src/dfa.c:#define STREQ(a, b) (strcmp (a, b) == 0)
>     src/main.c:#define STREQ(a, b) (strcmp (a, b) == 0)
>
> You may want to simply exempt those two files from that check.

There are not a lot of uses of STREQ in dfa.c. I'd be happy if you
expanded the macro there.  Gawk's STREQ checks  *a == *b before calling
strcmp, which is an OOOOLLLLDDDD speed hack from the PDP-11 / Vax
days. I should probably get rid of it.

Thanks,

Arnold



reply via email to

[Prev in Thread] Current Thread [Next in Thread]