[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] remove lib/ms/
From: |
Jim Meyering |
Subject: |
Re: [PATCH 3/3] remove lib/ms/ |
Date: |
Tue, 03 Jan 2012 21:45:18 +0100 |
Paolo Bonzini wrote:
> On 01/03/2012 07:21 PM, Paul Eggert wrote:
>> The point of lib/ms was so that if I do this:
>>
>> cd lib
>> grep something *.[ch]
>>
>> I don't find false matches for the Microsoft-specific stuff.
>> Now that lib/ms/* has been moved into lib/*, I can't do that
>> any more. I'd really like for the Microsoft-specific code
>> to be segregated better, so that I don't have to worry about it
>> normally.
>
> *-w32.c does the same. Also, gnulib has plenty of MS-specific stuff
> in lib/ and without even the -w32 suffix. Keeping a directory for the
> sake of 1 file didn't seem particularly useful.
I think it is worthwhile to keep windows-specific code separate.
Then there is a well-defined location for easily-encapsulated
pieces of windows-related code. Using a separate directory seems
like a practice that is more likely to be followed (and a little
cleaner) than one that inserts -w32 near the end of a file name.
[PATCH 2/3] unify colorize.h headers, Paolo Bonzini, 2012/01/03
[PATCH 3/3] remove lib/ms/, Paolo Bonzini, 2012/01/03