|
From: | Paul Eggert |
Subject: | bug#16912: [PATCH] no longer use CSET for non-UTF8 locale in DFA engine |
Date: | Sat, 01 Mar 2014 16:13:14 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
First, why does the first patch add those four using_utf8 calls to parse_bracket_exp? Isn't that optimization valid regardless of whether the multibyte encoding is UTF-8?
Second, the comment "UTF-8 allows treating a simple, non-inverted MBCSET like a CSET." no longer seems to match the code, since addtok no longer invokes using_utf8.
Third, could you please draft a proper commit message? The format is something like this:
grep: minor tuning for mb_case_map_apply * src/kwsearch.c (mb_case_map_apply): Avoid unnecessary widening of size_t to intmax_t. Avoid unnecessary reinitialization of k.That is, a first line of the form "program: short description". Then an empty line. Then a ChangeLog entry in standard GNU format.
I'll take a look at the second patch later.
[Prev in Thread] | Current Thread | [Next in Thread] |