bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16911: [PATCH] grep: fix bugs with -i and titlecase


From: Paul Eggert
Subject: bug#16911: [PATCH] grep: fix bugs with -i and titlecase
Date: Wed, 05 Mar 2014 11:37:08 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/03/2014 07:18 PM, Jim Meyering wrote:
You're right.  It was only to avoid warnings from gcc, and using #pragmas
is a better approach, in a project like grep where we rarely modify that code.

I just now checked, and without the grep diffs there are no warnings when I configure with grep's 'configure --enable-gcc-warnings' on Fedora 20 (gcc (GCC) 4.8.2 20131212 (Red Hat 4.8.2-7)). Possibly GCC got smarter, or possibly the pragmas in gnulib regex now suffice. So I've removed the grep diffs with the attached patch for now; if warnings come back (older compilers maybe?) we can add more pragmas to the gnulib copy.

Attachment: 0001-maint-remove-differences-from-gnulib-regex-code.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]