bug#18750: --line-buffered option doesn't work with --files-with-matches

[Jim Meyering]

On Mon, Oct 20, 2014 at 12:29 AM, Louis Sautier <address@hidden> wrote:
> I have no issue with this behaviour, I just wish one could have
> buffered null-separated output as well.
>
> On 19 October 2014 02:43, Norihiro Tanaka <address@hidden> wrote:
>> Jim Meyering <address@hidden> wrote:
>>> Thanks, but as a stand-alone patch, that makes grep fail to compile,
>>> because there is one remaining use of the variable whose declaration
>>> is removed.
>>
>> Sorry, I fixed it, and compiled and tested.
>>
>>> In any case, there is some ambiguity in the documentation
>>> about what "line" buffering means with -Z. With -l and -Z, should
>>> grep --line-buffered flush after printing each <file_name, NUL> pair?
>>> That's what I'd expect.
>>
>> I interprete the means as line buffered option `_IOLBF' of setvbuf, and
>> I think that many users will expect the behavior.  However, different
>> interpretations might also be present.

Thanks for the feedback.  What is your use case?
As I said above, I too would have expected -Z -l --line-buffered to flush
after each <file_name, NUL> pair.

Though note that the larger change would
have to update documentation clarifying that this also applies
to output that may not contain any newline.  It might even prompt
the addition of a new option name, --buffered, as a
more-aptly-named synonym for --line-buffered.

P.S., please do not "top post", i.e., reply after the bottom of the
quoted text, as I have done.