bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19252: [PATCH] dfa: matching at next position or infinit loop in mat


From: Norihiro Tanaka
Subject: bug#19252: [PATCH] dfa: matching at next position or infinit loop in matching mode
Date: Sun, 07 Dec 2014 16:50:20 +0900

On Sat, 6 Dec 2014 22:31:01 -0800
Jim Meyering <address@hidden> wrote:

> Thank you for adding that test program and a script to run it.
> I have made some changes:
> 
>   - reworded the commit logs
>   - removed the NEWS entry, since this is not a user-visible change
>   - changed a 4-line sequence in dfa.c to a single one using the
>       ternary operator:
> 
>      -      if (allow_nl)
>      -        s = d->newlines[s1];
>      -      else
>      -        s = 0;
>      +      s = allow_nl ? d->newlines[s1] : 0;
> 
>   - fixed the new "make syntax-check" violations induced
>       by the addition of that new .c file.
>   - changed the test script to use warn_ rather than printf
>   - replaced the full hex SHA1 in the log with the more useful
>       and readable "git desc ..." output: v2.5.4-144-gbafa134
> 
> See attached:

Thanks for the review and ajustment.  I confirmed that it can be built
and run correctly.  Can you push them?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]