bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19563: grep -F: fix a heap buffer (read) overrun


From: Jim Meyering
Subject: bug#19563: grep -F: fix a heap buffer (read) overrun
Date: Sun, 11 Jan 2015 17:49:22 -0800

On Sun, Jan 11, 2015 at 4:31 PM, Norihiro Tanaka <address@hidden> wrote:
...
> How about the attachments instead for the second patch?

Thank you for the suggestion.

However, I do not see a problem with Yuliy's fix, so have pushed it,
along with the other two commits.

Comparing your change to Yuliy's, I have a slight preference
for his, since it adds work only to the rarely-used code path on
which this bug was introduced, and keeps the handling of
"out of bounds TP" closer to the code that makes TP too large.

If you can provide justification for this proposed change,
would you please do so in the commit log of a rebased patch?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]