bug#16757: [PATCH 1/2] search for pcre via pkg-config

[Mike Frysinger]

On 25 May 2014 01:14, Paul Eggert wrote:
> --- a/m4/pcre.m4
> +++ b/m4/pcre.m4
>
> +  if test $test_pcre = yes; then

the previous code quoted test_pcre ... i guess previously it was normalized 
into 
"yes" and "no", but seems pretty cheap & easy to be resilient ?

> +    PKG_CHECK_MODULES([PCRE], [libpcre], [],
> +      [if test -r /usr/include/pcre/pcre.h &&
> +          test ! -r /usr/include/pcre.h
> +       then

ugh, but i guess i don't really care since this is the default and it can go 
poking around in whatever terrible way it wants.

> +         PCRE_CFLAGS=-I/usr/include/libpng

png eh ?

> +    if test "$pcre_cv_have_pcre_compile" = yes; then
> +      use_pcre=yes
> +    else
>        AC_MSG_WARN([AC_PACKAGE_NAME will be built without pcre support.])
>      fi

ideally this would error out if the user passed --enable-perl-regexp.  the 
test_pcre setup would have to pick like "auto" though in the default case.

> +  if test $use_pcre = yes; then

quote it ?
-mike

signature.asc
Description: Digital signature