bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex

[Norihiro Tanaka]

On Thu, 18 Aug 2016 09:21:56 -0600
address@hidden wrote:

> Norihiro Tanaka <address@hidden> wrote:
> 
> > The patch introduces not newline_anchor option of regex to dfa.  grep is
> > always newline_anchor, so newer codes is not used.  I expect it is used
> > by sed and gawk.
> >
> > However, the patch adds an argument to dfasyntax().   To synchronize
> > between grep and dfa easily, I expect it is applied before dfa is moved
> > to gnulib.
> 
> Can you update the comment to dfasyntax to explain the new fourth argument?
> 
> How would gawk call dfasyntax? It's not clear to me what you've just
> done.
> 
> Thanks,
> 
> Arnold

Hi Arnold,

If rp->pat.newline_anchor is false in gawk, dfa has been avoided.  dfa
is useful by passing a value of rp->pat.newline_anchor to the fourth
argument instead of the value, even if rp->pat.newline_anchor is false.


Hi Jim,

Where that is documented?

Thanks,
Norihiro