bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c


From: Norihiro Tanaka
Subject: bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c
Date: Sat, 20 Aug 2016 07:34:20 +0900

On Sat, 20 Aug 2016 07:25:06 +0900
Norihiro Tanaka <address@hidden> wrote:
> Hi Zev,
> 
> Thanks for replying.  I say a reverse thing.
> 
> I believe that there is no problem if only dfaexec() is thread safe.  In
> other words, I think that variables that we must really move to support
> multipthread are eolbyte, sbit and letters, newline only which depend
> on eolbyte, and mbrtowc_cache[] and never_trail should be changed as the
> value does not changed by other thread at running dfaexec() by marking
> already set, and we can leave other static and global as syntax etc.
> It will bring us to the saving of memory albeit only slightly.

Ah, I replied for first patch, but my all comments are for second or
later patches.  I agree for first patch entirely regardless of whether
we support multithread or not.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]