[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex
From: |
Norihiro Tanaka |
Subject: |
bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex |
Date: |
Sat, 03 Sep 2016 12:04:40 +0900 |
On Fri, 2 Sep 2016 15:35:22 -0700
Paul Eggert <address@hidden> wrote:
> Norihiro Tanaka wrote:
> > However, the patch adds an argument to dfasyntax(). To synchronize
> > between grep and dfa easily, I expect it is applied before dfa is moved
> > to gnulib.
>
> Since we're already changing the DFA API already, how about if we have a
> flags arg that combines all these little Boolean arguments? That will make
> future changes less disruptive. Although the existing code supports any
> newline terminator, in practice only '\0' and '\n' are useful, so it's really
> just a boolean.
>
> Most of the changes in your proposed patch are subsumed by the changes for
> multithreading, so the patch can be simplified now. I installed the attached,
> and plan to follow up shortly about the corresponding Gawk changes that I'll
> propose.
Thanks for reviewing. You say we can simplified by the changes for
multithreading, but two changes in the patch are needed.
0001-dfa-additional-change-new-option-for-anchored-search.patch
Description: Text document
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, Paul Eggert, 2016/09/02
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex,
Norihiro Tanaka <=
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, Paul Eggert, 2016/09/03
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, Norihiro Tanaka, 2016/09/03
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, Norihiro Tanaka, 2016/09/08
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, Paul Eggert, 2016/09/08
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, Norihiro Tanaka, 2016/09/08
- bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex, arnold, 2016/09/09