[bug #44767] grog(1) - build fails to substitute @grog_dir@ in generation of grog from src/roff/grog/grog.pl

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?44767>

                 Summary: grog(1) - build fails to substitute @grog_dir@ in
generation of grog from src/roff/grog/grog.pl
                 Project: GNU troff
            Submitted by: None
            Submitted on: Wed 08 Apr 2015 02:41:30 AM UTC
                Severity: 3 - Normal
              Item Group: Incorrect behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Greetings,

When building the git version of groff (2015/04/04) to check the fix
for https://savannah.gnu.org/bugs/?44708, I discovered that the
installed grog(1) did not function, with the error:

@grog_dir@ is not an existing directory; at
/pkgs/64-bit/release/groff-git_2014_04_04/bin/grog line 73.

Investigation showed that grog is constructed in the top-level
directory by the makefile fragment shown at the end of this message.

This makefile fragment comes from src/roff/grog/grog.am, which fails
to substitute the the string @grog_dir@ for $(grog_dir). The following
patch shows a possible solution to the issue.

--- ./src/roff/grog/grog.am.orig        2015-04-08 12:28:32.847135446 +1000
+++ ./src/roff/grog/grog.am     2015-04-08 12:29:19.132059779 +1000
@@ -43,6 +43,7 @@
            -e "s|address@hidden@]|$(DESTDIR)$(libdir)|g" \
            -e "s|address@hidden@]|$(EGREP)|g" \
            -e "s|address@hidden@]|$(VERSION)|" \
+           -e "s|address@hidden@]|$(grog_dir)|" \
            -e "$(SH_SCRIPT_SED_CMD)" \
            $(grog_srcdir)/grog.pl >$@
        chmod +x $@

Regards,
Peter Bray
Sydney, Australia


Sample Git Build, only relevant out shown (made 80 column friendly):

        bash  ./bootstrap
        ./configure --prefix=${INSTALLATION_PREFIX} \
                --with-libiconv-prefix=${PKGS_BASE_PREFIX} \
                --with-doc=yes --without-x
        gmake
        rm grog
        gmake 
gmake  all-am
gmake[1]: Entering directory `/tmp/64-bit/groff-git_2014_04_04'
rm -f grog
sed -f "./shdeps.sed" \
    -e "1s|^\(#! \).*perl|\\1/pkgs/64-bit/bin/perl|" \
    -e "s|address@hidden@]|g|g" \
    -e "s|address@hidden@]|/pkgs/64-bit/release/groff-git_2014_04_04/bin|g" \
    -e "s|address@hidden@]|/pkgs/64-bit/release/groff-git_2014_04_04/lib|g" \
    -e "s|address@hidden@]|/pkgs/64-bit/bin/ggrep -E|g" \
    -e "s|address@hidden@]|1.22.3|" \
    -e "1s/a/a/" \
    ./src/roff/grog/grog.pl >grog
chmod +x grog
gmake[1]: Leaving directory `/tmp/64-bit/groff-git_2014_04_04'

Corresponding generated Makefile fragment:

grog: $(grog_srcdir)/grog.pl $(GROG) $(SH_DEPS_SED_SCRIPT)
        $(RM) $@
        sed -f "$(SH_DEPS_SED_SCRIPT)" \
            -e "1s|^\(#! \).*perl|\\1$(PERL)|" \
            -e "s|address@hidden@]|$(g)|g" \
            -e "s|address@hidden@]|$(DESTDIR)$(bindir)|g" \
            -e "s|address@hidden@]|$(DESTDIR)$(libdir)|g" \
            -e "s|address@hidden@]|$(EGREP)|g" \
            -e "s|address@hidden@]|$(VERSION)|" \
            -e "$(SH_SCRIPT_SED_CMD)" \
            $(grog_srcdir)/grog.pl >$@
        chmod +x $@





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44767>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/