[bug #44768] gdiffmk(1) is not Solaris 10 /bin/sh compatible - PATCH provided

[Peter Bray]

Follow-up Comment #3, bug #44768 (project groff):

Sorry I was wrong about the "shift", the right number of shifts are present.

I decided to continue to test against Solaris 10 /bin/sh, and the following
patch (attached to preserve whitespace) seems to be fine.

Comments:
  - Changed the for loop to a while loop
  - Not all test(1) commands support -e (which is truly sad)

Basic execution runs to completion. Modified Line shows change bar :-)

Regards,
Peter

--- ./contrib/gdiffmk/gdiffmk.sh.orig   2015-04-10 19:37:02.502452458 +1000
+++ ./contrib/gdiffmk/gdiffmk.sh        2015-04-12 11:58:07.794180659 +1000
@@ -82,7 +82,7 @@
                ;;
        esac
 
-       if test ! -e "$2"
+       if test ! -f "$2"
        then
                Exit $1 "File `$2' not found."
        fi
@@ -159,8 +159,10 @@
 DIFFCMD=diff
 D_option=
 br=.br
-for OPTION
+
+while [ $# -gt 0 ]
 do
+       OPTION="${1}"
        case "${OPTION}" in
        -a*)
                ADDMARK=`RequiresArgument "${OPTION}" $2`               &&


(file #33643)
    _______________________________________________________

Additional Item Attachment:

File name: gdiffmk.patch                  Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44768>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/