Whoops! Re: [PATCH] Another semi-critical one... (was Re: towards 0.91 )

[erich]

address@hidden wrote:

> I just found another semi-critical bug, whose fix should really get
> into 0.91.
> 
> It turns out that "grub-install" doesn't have any "sync" calls to make
> sure any filesystem caches are coherent with the raw devices they are
> on top of...  so if your filesystem waits to write out any data from the
> copy command in the script to put the "stage1" and "stage2" in their
> final location, you're hosed.
> 
> I found this because it just bit me on one of my systems running stock
> RedHat 7.2 with a large "stage2".

OK, I feel a bit sheepish...

"sync" is already being called from the grub shell, which only makes
sense...  so in general the fix I posted should have been a no-op.  It's
not a bug per se, just unnecessary.

But on RedHat 7.2 with the kernel update to 2.4.9-7, something is
busted to make me have to call it explicitly in the shell script.

Effectively, the "sync" call was made several times with some small
delays in-between.

OK, I'll complain about this to RedHat...

--
    Erich Stefan Boleyn     <address@hidden>     http://www.uruk.org/
"Reality is truly stranger than fiction; Probably why fiction is so popular"