Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 12.06.2012 21:37, address@hidden wrote:

> -
> -  mmap_size = (1 << 12);
> -  while (1)
> -    {
> -      int ret;
> -      grub_efi_memory_descriptor_t *mmap;
> -      grub_efi_uintn_t desc_size;
> -
> -      mmap = grub_malloc (mmap_size);
> -      if (! mmap)
> -     return 0;
> -
> -      ret = grub_efi_get_memory_map (&mmap_size, mmap, 0, &desc_size, 0);
> -      grub_free (mmap);
> -
> -      if (ret < 0)
> -     {
> -       grub_error (GRUB_ERR_IO, "cannot get memory map");
> -       return 0;
> -     }
> -      else if (ret > 0)
> -     break;
> -
> -      mmap_size += (1 << 12);
> -    }
> +  if (grub_efi_get_memory_map (&mmap_size, mmap_buf, 0, &desc_size, 0) < 0)
> +    return grub_error (GRUB_ERR_IO, "couldn't retrieve memory map");
Please don't do this change. It's meant as workaround if EFI doesn't actually 
update mmap_size. I'll look into as to why my patch crashed.  



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature