[bug #48102] grub-2.02_beta2: grub2-mkconfig does not allow serial_usb0 as terminal

[Horst Prote]

URL:
  <http://savannah.gnu.org/bugs/?48102>

                 Summary: grub-2.02_beta2: grub2-mkconfig does not allow
serial_usb0 as terminal
                 Project: GNU GRUB
            Submitted by: prote
            Submitted on: Do 02 Jun 2016 19:23:54 CEST
                Category: Configuration
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: other
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

Under Gentoo Linux with sys-boot/grub-2.02_beta2-r9 I get this error:

With


GRUB_TERMINAL_INPUT="usb_keyboard0 serial_usb0 console"
GRUB_TERMINAL_OUTPUT="serial_usb0 console"
GRUB_SERIAL_COMMAND="sleep --verbose --interruptible 1; serial --speed=115200
usb0"
GRUB_PRELOAD_MODULES="nativedisk ehci ohci uhci usb usbserial_ftdi"


in /etc/default/grub you get:


# grub2-mkconfig -o /boot/grub/grub.cfg
Invalid output terminal "serial_usb0 console"


This can be fixed by changing /usr/sbin/grub2-mkconfig from


for x in ${GRUB_TERMINAL_OUTPUT}; do
    case "x${x}" in
        xgfxterm) ;;
        xconsole | xserial | xofconsole | xvga_text)
            # make sure all our children behave in conformance with ascii..
            export LANG=C;;
        *) echo "Invalid output terminal \"${GRUB_TERMINAL_OUTPUT}\"" >&2 ;
exit 1 ;;
    esac
done


to (note the appended * after xserial)


for x in ${GRUB_TERMINAL_OUTPUT}; do
    case "x${x}" in
        xgfxterm) ;;
        xconsole | xserial* | xofconsole | xvga_text)
            # make sure all our children behave in conformance with ascii..
            export LANG=C;;
        *) echo "Invalid output terminal \"${GRUB_TERMINAL_OUTPUT}\"" >&2 ;
exit 1 ;;
    esac
done


But now the GRUB_SERIAL_COMMAND isn't added to grub.cfg because of the
following lines
in /etc/grub.d/00_header


for x in ${GRUB_TERMINAL_INPUT} ${GRUB_TERMINAL_OUTPUT}; do
    if [ xserial = "x$x" ]; then
    serial=1;
    fi
    if [ xgfxterm = "x$x" ]; then
    gfxterm=1;
    fi
done


After changing these lines to


for x in ${GRUB_TERMINAL_INPUT} ${GRUB_TERMINAL_OUTPUT}; do
    case "x${x}" in
    xgfxterm) gfxterm=1;;
    xserial*) serial=1;;
    esac
done


now


# grub2-mkconfig -o /boot/grub/grub.cfg


creates a valid and working config.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48102>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/