Re: [Bug-gsl] [Help-gsl] test release for gsl-2.0

[David Binderman]

Hello there Patrick,

----------------------------------------
> Thanks, I've never used that tool before. I've corrected these issues

Cppcheck is available from sourceforge.

I also tried out a build with a recent version of clang.

I got

1.

coulomb.c:994:17: warning: variable 'G_lam_G' is uninitialized when used here 
[-Wuninitialized]
coulomb.c:996:17: warning: variable 'Gp_lam_G' is uninitialized when used here 
[-Wuninitialized]

I am not sure why gcc didn't find these problems. These problems do seem to be 
in a chunk
of code that claims to be never executed.

2.

exp.c:216:83: warning: using floating point absolute value function 'fabs' when 
argument is of integer type [-Wabsolute-value]

Suggest use abs in preference to fabs.

3.

gamma.c:1614:54: warning: taking the absolute value of unsigned type 'unsigned 
int' has no effect [-Wabsolute-value]

4.

hyperg_1F1.c:1004:44: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1035:45: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1058:24: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1087:40: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1114:22: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1170:22: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1814:41: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1814:68: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1818:41: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]
hyperg_1F1.c:1818:66: warning: using floating point absolute value function 
'fabs' when argument is of integer type [-Wabsolute-value]

Suggest use abs in preference to fabs.

5.

hyperg_U.c:285:38: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:861:45: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:871:11: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:881:11: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:881:11: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:913:38: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:947:39: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:998:35: warning: using floating point absolute value function 'fabs' 
when argument is of integer type [-Wabsolute-value]
hyperg_U.c:1042:48: warning: using floating point absolute value function 'fabs'
 when argument is of integer type [-Wabsolute-value]
hyperg_U.c:1108:49: warning: using floating point absolute value function 'fabs'
 when argument is of integer type [-Wabsolute-value]
hyperg_U.c:1439:57: warning: using floating point absolute value function 'fabs'
 when argument is of integer type [-Wabsolute-value]
hyperg_U.c:1650:52: warning: using floating point absolute value function 'fabs'
 when argument is of integer type [-Wabsolute-value]

6.

legendre_poly.c:401:67: warning: using floating point absolute value function 'f
abs' when argument is of integer type [-Wabsolute-value]
legendre_poly.c:439:93: warning: using floating point absolute value function 'f
abs' when argument is of integer type [-Wabsolute-value]
poch.c:164:46: warning: using floating point absolute value function 'fabs' when
 argument is of integer type [-Wabsolute-value]
poch.c:179:47: warning: using floating point absolute value function 'fabs' when
 argument is of integer type [-Wabsolute-value]
./absdev_source.c:41:28: warning: absolute value function 'fabs' given an argume
nt of type 'long double' but has parameter of type 'double' which may cause trun
cation of value [-Wabsolute-value]
./wabsdev_source.c:43:35: warning: absolute value function 'fabs' given an argum
ent of type 'long double' but has parameter of type 'double' which may cause tru
ncation of value [-Wabsolute-value]

Regards

David Binderman