[bug #21378] guile 1.8.3 numbers.c fails to compile in Solaris 9

[Ludovic Courtès]

Update of bug #21378 (project guile):

             Assigned to:                    None => civodul                

    _______________________________________________________

Follow-up Comment #3:

Sorry for taking soooo long to handle this.

It appears that the main issue here is that all these functions are declared
`extern' in "numbers.h", and then defined "inline" in `numbers.c'.

>From my understanding of the standard (summarized in Bruno Haible's message
that you cited), this isn't correct: the function should have been either
declared "extern inline", in which case its definition should appear in every
translation unit, or the function is just declared "extern", in which case it
cannot be defined "inline".

So I suggest removing the "inline" keyword for all these definitions.  It
appears that this does not affect the code generated by GCC -O2, as evidenced
by "objdump -d numbers.o", since all calls to these functions within
`numbers.c' *are* inlined (calls from outside are not inlined, which is
normal).

Please, try out the attached patch and let me know if it works with Sun CC.

Thanks!

Ludovic.

(file #14954)
    _______________________________________________________

Additional Item Attachment:

File name: ,,numbers-inline.diff          Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21378>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/