Re: errors building guile 1.8.6 for Interix, with some small patches

[Neil Jerram]

With apologies for the lateness of this response...

Jay <address@hidden> writes:

> /src/guile-1.8.6/libguile/filesys.c: In function `scm_readdir':
> /src/guile-1.8.6/libguile/filesys.c:918: warning: implicit declaration of
> functi
> on `readdir_r'

[...]

> Surely:
> #if !defined(_REENTRANT) && defined(__INTERIX)
> would also work if you want to narrow it down (but stime.c doesn't).

I've committed this fix.  Given the maturity of 1.8.x, I went for the
ultraconservative option.

> /src/guile-1.8.6/libguile/posix.c: In function `scm_seteuid':
> /src/guile-1.8.6/libguile/posix.c:728: warning: implicit declaration of
> function
> `seteuid'
[...]
> I don't see these prototyped anywhere.
[...]
> C:\src\guile-1.8.6\libguile>\cygwin\bin\diff -u posix.c.orig posix.c
> --- posix.c.orig 2008-12-08 09:42:55.000000000 -0800
> +++ posix.c 2009-06-19 11:39:28.500000000 -0700
> @@ -724,7 +724,7 @@
> {
> int rv;
> -#ifdef HAVE_SETEUID
> +#if defined(HAVE_SETEUID) && !defined(__INTERIX)
> rv = seteuid (scm_to_int (id));
> #else
> rv = setuid (scm_to_int (id));

I haven't committed this and similar changes, because it seems to me
that if HAVE_SETEUID is defined, seteuid must actually be provided by
one of the Interix libraries, and someone else might want to use it via
Guile.  If there really is no header file that declares these functions,
but they are implemented by libraries, wouldn't it be nicer to add the
necessary prototype?

Regards,
      Neil