bug#29226: fresh-auto-compile doesn’t invalidate the compilation cache

[Ludovic Courtès]

Andy Wingo <address@hidden> skribis:

> On Mon 15 Jan 2018 15:33, address@hidden (Ludovic Courtès) writes:
>
>> Hello,
>>
>> address@hidden (Ludovic Courtès) skribis:
>>
>>> ‘%fresh-auto-compile’ is documented as a way to “forcibly invalidate the
>>> auto-compilation cache” (info "(guile) Compilation"), but it seems that
>>> it doesn’t invalidate much.  Specifically, ‘primitive-load-path’ does:
>>>
>>>   compiled_thunk = load_thunk_from_path (filename, full_filename, 
>>> &stat_source,
>>>                                          &found_stale_compiled_file);
>>>
>>>   if (scm_is_false (compiled_thunk)
>>>       && scm_is_false (*scm_loc_fresh_auto_compile)
>>>       …)
>>>     { … }
>>>
>>>   …
>>>
>>>   if (scm_is_true (compiled_thunk))
>>>     return scm_call_0 (compiled_thunk);
>>>   else
>>>     {
>>>       SCM freshly_compiled = scm_try_auto_compile (full_filename);
>>>       …
>>>     }
>>>
>>> So if there’s a .go file in the search path, it is *always* loaded, and
>>> there’s no way we reach ‘scm_try_auto_compile’.
>>>
>>> ‘load-absolute’ in boot-9.scm seems to have the same problem:
>>>
>>>   (and scmstat (or (pre-compiled) (fallback)))
>>>
>>> I believe the attached patch fixes it.
>>
>>> Pushed as 83d4c4d622b406ec0bc9d8139ec8182fa72b5720.
>>
>> As we’ve discussed since then, this patch was misguided:
>> ‘%fresh-auto-compile’ is about ~/.cache, so the fact that .go files
>> found elsewhere in the search path get loaded is expected.
>>
>> My apologies for breaking this!
>>
>> So I guess we should revert 83d4c4d622b406ec0bc9d8139ec8182fa72b5720 and
>> release 2.2.4 afterwards.  Does that make sense, Andy?
>
> Makes sense to me, yes!

OK, reverted in a1793bc904d947810d64175945218c2cdace38cc.

Thanks,
Ludo’.