Re: [PATCH] distro: Add Libusb.

[Ludovic Courtès]

Hi,

Nikita Karetnikov <address@hidden> skribis:

> /tmp/nix-build-libusb-1.0.9.drv-0/libusb-1.0.9/libtool: line 1113:
> ldconfig: command not found

Yes, we don’t use ldconfig(1).  This warning is harmless.

> strip:/nix/store/1x3fy2fs9p4k80asqcasji82lhhfb5hp-libusb-1.0.9/lib/libusb-1.0.la:
> File format not recognized
> strip:/nix/store/1x3fy2fs9p4k80asqcasji82lhhfb5hp-libusb-1.0.9/lib/pkgconfig/libusb-1.0.pc:
> File format not recognized

Harmless too: strip just warns about non-ELF files it is passed.

> I was using the following settings.
>
> nix.conf:
>
> build-users-group = nixbld
> build-use-chroot = true
> build-chroot-dirs = /dev /proc /bin
>
> or
>
> # ./pre-inst-env guix-daemon --build-users-group=nixbld \
>> -C 0 --chroot-directory=/bin &

Good.

> Can I commit it?

Yes, please!  One minor thing below:

> +    (synopsis "Libusb is a user-space USB library")

The synopsis should not be a sentence; instead, it should be a concise
phrase.  So I’d replace “ is” by “, ” here.

Ludo’.