[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: /bin/sh in configure tests
From: |
Ludovic Courtès |
Subject: |
Re: /bin/sh in configure tests |
Date: |
Wed, 16 Jan 2013 15:33:41 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
Hello!
Andreas Enge <address@hidden> skribis:
> Yes, it does! Attached is a patch for a new package. If it is okay, I can
> push it.
Just minor nitpicking below, but if it builds in a chroot without /bin
or anything, please push!
> + (inputs `(("perl" ,perl)
> + ))
Please put closing parentheses at the end of the line.
> + (arguments
> + (lambda (system)
Since the ‘system’ variable isn’t used, you don’t need a lambda here.
Instead you can just write:
(arguments
`(#:phases ...))
> + (substitute* "configure"
> + (("`/bin/sh")
> + (string-append "`" (which "bash"))))
The opening parenthesis on the second line is normally aligned with the
‘u’ of ‘substitute*’. :-)
Thanks,
Ludo’.