[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Replace individual scripts with master 'guix' script
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] Replace individual scripts with master 'guix' script |
Date: |
Thu, 14 Feb 2013 18:13:40 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Hi Ludovic,
Thanks for the quick feedback. I've attached a new patch that
incorporates almost all of your suggestions, and also includes a basic
find/replace in the manual (though more work is needed there).
> • Remove the ‘guix-’ prefix from module names, so
> guix/scripts/build.scm instead of guix/scripts/guix-build.scm;
>
> • No need to add .gitignore to change logs;
>
> • Make sure to update po/POTFILES.in;
Done.
> • Arrange commits such that everything always works; thus, update
> tests to use the new command names in the same commit that changes
> those commands.
Indeed. The reason I initially kept the test updates separated is
because I wasn't sure if we wanted to continue supporting the old style
"guix-package" and friends. However, we agreed on IRC to abandon the
old style, so that's what this patch now does.
> (install-locale)
> (textdomain "guix")
> (setvbuf (current-output-port) _IOLBF)
> (setvbuf (current-error-port) _IOLBF)
Done.
> We also need to support --version and --help here, using SRFI-37 as is
> the current scripts.
I now support --version and --help, but I didn't see how to use SRFI-37
in the main driver, because it doesn't know the full set of options to
accept.
> + (format (current-error-port)
> + "Usage: guix <command> [<args>]~%")
>
> Messages must be i18n’d, and use standard GNU notation:
>
> Usage: guix COMMAND ARGS...
Done.
Here's the new patch, compressed this time. Please let me know what you
think. I think this might be about ready to push.
Mark
0001-Replace-individual-scripts-with-master-guix-script.patch.gz
Description: [PATCH] Replace individual scripts with master 'guix' script
- Re: [PATCH] Improve shell script headers and pre-inst-env handling, (continued)
- Re: [PATCH] Improve shell script headers and pre-inst-env handling, Ludovic Courtès, 2013/02/12
- Re: [PATCH] Improve shell script headers and pre-inst-env handling, Mark H Weaver, 2013/02/12
- Re: [PATCH] Improve shell script headers and pre-inst-env handling, Mark H Weaver, 2013/02/13
- Re: [PATCH] Improve shell script headers and pre-inst-env handling, Ludovic Courtès, 2013/02/13
- Re: [PATCH] Improve shell script headers and pre-inst-env handling, Mark H Weaver, 2013/02/14
- [PATCH] Replace individual scripts with master 'guix' script, Mark H Weaver, 2013/02/14
- Re: [PATCH] Replace individual scripts with master 'guix' script, Ludovic Courtès, 2013/02/14
- Re: [PATCH] Replace individual scripts with master 'guix' script,
Mark H Weaver <=
- Re: [PATCH] Replace individual scripts with master 'guix' script, Ludovic Courtès, 2013/02/16
- Re: [PATCH] Replace individual scripts with master 'guix' script, Ludovic Courtès, 2013/02/17