Re: #!/usr/bin/env perl

[Andreas Enge]

Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès:
> > (make-regexp
> > "^[[:blank:]]*([[:graph:]]+)[[:blank:]]*([[:graph:]]*)(.*)$")))
> 
> I think it should be a + after the second [[:blank:]], because there
> should be space between the interpreter name and its argument.

Sometimes, there is no space at all: In
#!/usr/bin/perl
for instance, when there is no argument. Then the "+" version would fail. 
With "*", it works as expected.

> What about more descriptive names like ‘interp’, ‘arg1’, and ‘rest’?

Maybe. I did not choose descriptive names because the real interpreter is 
sometimes the first, sometimes the second piece. But your suggestion looks 
good.

> Rather (has-env? (string-suffix? "/env" interp)).

Ok, thanks.

> > +                                    (if has-env
> > +                                      (begin
> Please align with the ‘h’ here...
> > +                                        (patch p bin
> > +                                          (string-append " " second
> > third)))))
> ... and with the ‘p’ here.

Ok. The annoying thing with this way of indenting is that lines become very 
long very quickly; I like keeping them at less than 80 characters.

Andreas