Re: [PATCH] gnu: Add dwm.

[Ludovic Courtès]

Hi!

Cyril Roelandt <address@hidden> skribis:

> This patch can be applied again the xorg branch. It adds dwm, which may not be
> extremely useful since, according to its developers "because dwm is customized
> through editing its source code, it’s pointless to make binary packages of 
> it".

Interesting.  :-)

> I had to turn '${CC}' into 'gcc' in the Makefile, because ${CC} was 'cc', and
> there was no 'cc' command available. Would it make sense to create a symlink
> when installing gcc ?

Dunno.  It’s the first time we see this, no?

> +         (lambda* (#:key outputs #:allow-other-keys)
> +          (let ((out (assoc-ref outputs "out")))
> +           (zero?
> +            (system* "make" "install"
> +             (string-append "DESTDIR=" out) "PREFIX="))))

“(string-append” should be aligned with "make".

Is it really DESTDIR and not PREFIX that must be set?

> +    (license "x11")))

Typo: should be ‘x11’ (the variable).

Thanks!

Ludo’.