[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29492: tests/guix-system.sh failure on unbound variable check
From: |
Eric Bavier |
Subject: |
bug#29492: tests/guix-system.sh failure on unbound variable check |
Date: |
Tue, 28 Nov 2017 19:25:03 +0000 |
Hello Guix,
Latest guix master (2cdf78df2d3d5d88c7e6908754233cf37cce1e61) fails
tests/guix-system.sh for me, on line 128. This seems to be caused by the fact
that the error output contains a multi-character column number:
```
/tmp/bavier/tmpfile:9:14: In procedure #<procedure 3aba2820 ()>:
/tmp/bavier/tmpfile:9:14: GRUB-config: unbound variable
hint: Did you forget a `use-modules' form?
./test-env: line 1: 59998 Terminated
"/home/users/bavier/src/guix/pre-inst-env"
"/home/users/bavier/src/guix/guix-daemon" --disable-chroot
--substitute-urls="$GUIX_BINARY_SUBSTITUTE_URL"
```
Which is not matched by the current grep pattern. This patch fixes the issue
for me, as a follow-up to commit b70d72ac47fdc9364a64bd22962b2e11524e38b2
```
diff --git a/tests/guix-system.sh b/tests/guix-system.sh
index 4bb866a..2138648 100644
--- a/tests/guix-system.sh
+++ b/tests/guix-system.sh
@@ -123,9 +123,9 @@ else
then
# FIXME: With Guile 2.2.0 the error is reported on line 4.
# See <http://bugs.gnu.org/26107>.
- grep "$tmpfile:[49]:[0-9]: GRUB-config.*[Uu]nbound variable"
"$errorfile"
+ grep "$tmpfile:[49]:[0-9]\+: GRUB-config.*[Uu]nbound variable"
"$errorfile"
else
- grep "$tmpfile:9:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
+ grep "$tmpfile:9:[0-9]\+: GRUB-config.*[Uu]nbound variable" "$errorfile"
fi
fi
```
Eric Bavier, Scientific Libraries, Cray Inc.
- bug#29492: tests/guix-system.sh failure on unbound variable check,
Eric Bavier <=