[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34531: Guix profile fails on Overdrive 1000
From: |
Danny Milosavljevic |
Subject: |
bug#34531: Guix profile fails on Overdrive 1000 |
Date: |
Sun, 24 Feb 2019 13:12:07 +0100 |
Hi Ricardo,
On Sun, 24 Feb 2019 12:45:34 +0100
Ricardo Wurmus <address@hidden> wrote:
> Danny Milosavljevic <address@hidden> writes:
>
> > Final version attached. Works fine now.
>
> The loop looks a bit more complicated than it needs to be, I think. Did
> my version not work for you?
It did, but I wanted to make sure the port did exactly the same as the
original generate.py--maybe I overdid it, but I didn't want to break it
by porting it.
What skip_comments in the original does is strip comments, but not strip
"comment-like things" that are in string literals ("/*blah*/").
(as far as I can tell, at least)
I agree your version is easier but does it do the same thing?
Attached a v2 where I fixed a bug in literal handling related to that (oops).
WDYT?
generate.scm
Description: Text Data
pgpSIIqNHuIAM.pgp
Description: OpenPGP digital signature
- bug#34531: Guix profile fails on Overdrive 1000, (continued)
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Ricardo Wurmus, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Ricardo Wurmus, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/20
- bug#34531: Guix profile fails on Overdrive 1000, Ricardo Wurmus, 2019/02/23
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/24
- bug#34531: Guix profile fails on Overdrive 1000, Ricardo Wurmus, 2019/02/24
- bug#34531: Guix profile fails on Overdrive 1000,
Danny Milosavljevic <=
- bug#34531: Guix profile fails on Overdrive 1000, Ricardo Wurmus, 2019/02/26
- bug#34531: Guix profile fails on Overdrive 1000, Andreas Enge, 2019/02/19
- bug#34531: Guix profile fails on Overdrive 1000, Danny Milosavljevic, 2019/02/19