[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field.
From: |
Maxim Cournoyer |
Subject: |
bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field. |
Date: |
Sat, 29 Apr 2023 13:16:36 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Liliana,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Samstag, dem 29.04.2023 um 08:26 +0200 schrieb Liliana Marie
> Prikler:
>> IIRC using supplementary groups does not suffice, because the
>> service won't work then; do I actually recall that correctly?
> Reading the rest of the series it turns out that worry was unwarranted.
> Supplementary groups do work as they should.
Perhaps the simplest, more natural way to fix this would be to do the
following:
1. Revert to use simple strings for the user/group, with their types to
maybe-string.
2. When the fields are specified, it's assumed that their corresponding
user/group already exist, as done for other services. When unspecified,
then the service takes care to extend the user-accounts service with the
mpd user/group.
This means we do not have to expose user-accounts at the
<mpd-configuration>, which is not the right place for that anyway; it's
already exposed via the users/groups fields of the <operating-system>
record.
That's much easier to reason with, for both humans and the code, in my
opinion.
--
Thanks,
Maxim
- bug#63082: [PATCH 15/17] services: mpd: Provision a default cache directory and set HOME., (continued)
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field.,
Maxim Cournoyer <=
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/04/30
bug#63082: [PATCH 02/17] services: mpd: Streamline mpd-user-sanitizer and mympd-user-sanitizer., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 03/17] services: mpd: Rename %set-user-group to set-user-group., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 06/17] services: mympd: Fix log file name., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 13/17] services: mpd: Fix indentation., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 09/17] services: mpd: Let Shepherd effect the user/group change., Maxim Cournoyer, 2023/04/28