bug-gzip
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Fix old 'tail +' syntax in gzexe.in


From: Matthew Burgess
Subject: Re: [Patch] Fix old 'tail +' syntax in gzexe.in
Date: Tue, 28 Nov 2006 10:51:28 +0000
User-agent: Thunderbird 1.5.0.8 (X11/20061117)

Paul Eggert wrote:
Matthew Burgess <address@hidden> writes:

A simple grep shows the following two occurrences of the old syntax
still exist though:

gzexe.in:if tail +$skip "$0" | "BINDIR"/gzip -cd > "$gztmp"; then
gzexe.in:    if $tail +$skip "$i" | gzip -cd > $tmp; then

I don't see how the bug could occur.

Nope, neither do I. I guess that's what I get for just performing a simple grep on the source.

Are you sure those instances are actually bugs?  That is, did you test
it, and reproduce the bug?

No, I didn't test it.  Now that I try to, all I get is:

$ cp /usr/bin/ls .
$ gzexe ./ls
usr/bin/gzexe: line 97: gz5261: cannot overwrite existing file
: compression not possible for ./ls, file unchanged.

I've attached the output of running `gzexe' with a 'set -x' option in case it'll help figure out what's going on here?

Regards,

Matt.
+ version='gzexe (gzip) 1.3.6
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software.  You may redistribute copies of it under the terms of
the GNU General Public License <http://www.gnu.org/licenses/gpl.html>.
There is NO WARRANTY, to the extent permitted by law.

Written by Jean-loup Gailly.'
+ usage='Usage: gzexe [OPTION] FILE...
Rename each FILE with a compressed version of itself, renaming FILE to FILE~.

  -d             Decompress each FILE instead of compressing it.
      --help     display this help and exit
      --version  output version information and exit

Report bugs to <address@hidden>.'
+ PATH=/usr/bin:/bin:/usr/bin:/sbin:/usr/sbin
+ test 1 = 0
+ decomp=0
+ res=0
+ :
+ case $1 in
+ break
+ tmp=gz5454
+ trap 'rm -f gz5454; exit 1' 1 2 3 5 10 13 15
+ set -C
+ echo hi
+ test -z '++ cpmod gz5454 gz5454
/usr/bin/gzexe: line 75: cpmod: command not found'
+ tail=
+ IFS='         
'
+ saveifs='     
'
+ IFS='         
:'
+ for dir in '$PATH'
+ test -z /usr/bin
+ test -f /usr/bin/tail
+ tail=/usr/bin/tail
+ break
+ IFS='         
'
+ test -z /usr/bin/tail
+ case `echo foo | $tail -n +1 2>/dev/null` in
++ echo foo
++ /usr/bin/tail -n +1
+ tail='/usr/bin/tail -n'
+ for i in '"$@"'
+ test '!' -f ./ls
+ test 0 -eq 0
+ grep '^skip=[0-9]*$'
+ sed -e 1d -e 2q ./ls
+ ls -l ./ls
+ grep '^...[sS]'
+ ls -l ./ls
+ grep '^......[sS]'
+ case "$i" in
+ test -z ''
+ cp -p ./ls gz5454
+ test -w gz5454
+ writable=1
+ :
+ test 0 -eq 0
/usr/bin/gzexe: line 97: gz5454: cannot overwrite existing file
+ /bin/rm -f gz5454
+ echo : compression not possible for ./ls, file unchanged.
: compression not possible for ./ls, file unchanged.
+ res=1
+ continue
+ exit 1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]