[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pfinet: configure_dev does not initialize the ifa correctly
|
From: |
Marcus Brinkmann |
|
Subject: |
Re: [PATCH] pfinet: configure_dev does not initialize the ifa correctly |
|
Date: |
Wed, 18 Jul 2001 19:33:33 +0200 |
|
User-agent: |
Mutt/1.3.18i |
On Wed, Jul 18, 2001 at 07:04:02PM +0200, Marcus Brinkmann wrote:
>
> > @@ -435,7 +440,7 @@ configure_device (struct device *dev,
> > if (peer != INADDR_NONE && (dev->flags & IFF_POINTOPOINT))
> > {
> > ifa->ifa_prefixlen = 32;
> > - if (netmask != INADDR_NONE)
> > + if (netmask != INADDR_NONE && !(dev->flags & IFF_POINTOPOINT))
> > ifa->ifa_mask = netmask;
> > else
> > ifa->ifa_mask = inet_make_mask(32);
>
> I don't understand this part of the patch.
How about this:
@@ -435,10 +440,7 @@
if (peer != INADDR_NONE && (dev->flags & IFF_POINTOPOINT))
{
ifa->ifa_prefixlen = 32;
- if (netmask != INADDR_NONE)
- ifa->ifa_mask = netmask;
- else
- ifa->ifa_mask = inet_make_mask(32);
+ ifa->ifa_mask = inet_make_mask(32);
ifa->ifa_address = peer;
}
Marcus
--
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann GNU http://www.gnu.org marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de