Re: gnumach and strpbrk

[Niels Möller]

tb@becket.net (Thomas Bushnell, BSG) writes:

> Marcus Brinkmann <Marcus.Brinkmann@ruhr-uni-bochum.de> writes:
> 
> > I suggest to add strpbrk to the allowed symbols to be taken from glibc, and
> > remove the strpbrk definition in the glue code.  Thinking about it, we
> > should probably remove the strstr, strspn, strtok from the glue code as
> > well, and just take them from glibc.
> 
> That is surely the right thing to do for all such functions.

Except for strtok... That strtok is used at all in the linux kernel is
a bug. This was discussed by tytso and some other kernel people over
lunch at the Erlangen Linux-Kongress some months ago, and the
conclusion was that the broken strtok interface would actually cause
real problems in some cases. IIRC correctly, strtok is used primarily
for parsing arguments when modules are initialized (at boot time or
module load time), and it will break if you have an SMP system and
load several modules at about the same time.

Greping through linux-2.4.9, there seems to be about 80 files that
(still) use strtok.

Regards,
/Niels