Re: hostname again.

[James Morrison]

It seems my assumption of Rolands patch being in the debian tree is
wrong.

--- "Thomas Bushnell, BSG" <tb@becket.net> wrote:
> James Morrison <rocketmail_com@rocketmail.com> writes:
> 
> > -  err = __dir_mkfile (dir, O_WRONLY, 0644, &new);
> > +  err = __dir_mkfile (dir, O_WRITE, 0644, &new);
> 
> Hrm.  
> 
> O_WRITE is surely better than O_WRONLY, but they are equal in fact.
> 
> And the implementation of dir-mkfile.c in libdiskfs always turns on
> O_READ, O_WRITE, and O_EXEC anyway, regardless of what you asked
> for.

Actually, O_READ, O_WRITE, O_EXEC are the only things that can be
turned on.  So O_CREAT, O_TRUNC are ignorned.  Should libnetfs be
change to limit the usable flags to O_READ, O_WRITE, and O_EXEC as
well?  In libnetfs flags are directly passed down to make_peropen()
and then put into po->openstat .  libtrivfs doesn't support
dir_mkfile
so that shouldn't make a difference ;).

So a change from O_WRONLY and O_WRITE is completly cosmetic.

> I'm not sure why it does this (is it really the right Posix
> semantics??).  
> 
> O_CREAT is entirely ignored here.  The flags are used only to
> initialize the peropen for the returned port.
> 
> So if this fixes anything, I'm entirely mystified why.  I'd rather
> not
> see the change checked in without understanding it.
> 
> Thomas
> 
> _______________________________________________
> Bug-hurd mailing list
> Bug-hurd@gnu.org
> http://mail.gnu.org/mailman/listinfo/bug-hurd


=====
James Morrison
   University of Waterloo
   Computer Science - Digital Hardware
   2A co-op
http://hurd.dyndns.org

Anyone refering this as 'Open Source' shall be eaten by a GNU

__________________________________________________
Do You Yahoo!?
Great stuff seeking new owners in Yahoo! Auctions! 
http://auctions.yahoo.com