Re: [Fwd: [bug #6047] rm -f "" prints diagnostic message under the Hurd]

[Thomas Bushnell, BSG]

Roland McGrath <roland@frob.com> writes:

> Off hand I don't see anything that relies on the EINVAL error from
> diskfs_lookup to distinguish this case.  Hence no harm in making it ENOENT
> there.  

The really important thing is to make sure that diskfs_lookup of ""
still works the same way.  That is special cased in diskfs_lookup
anyhow, but still, this is the case to be especially worried about
because many things subtly depend on it.

I would rather not do this, in other words.

> The rationale for it returning EINVAL is that "" (like anything
> with infix slashes) is an inappropriate argument for "file name within
> directory" arguments to RPCs.  That seems sensible to me as well.  So,
> conversely, clients should not be sending such RPCs and libc is what needs
> to change.  

I believe that this is actually the right thing to do.  I would much
rather do it this way and change glibc to not issue such RPCs.  So I'm
all for this solution.

Thomas