bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

netfs and O_NONBLOCK


From: Marco Gerards
Subject: netfs and O_NONBLOCK
Date: Sat, 24 Jul 2004 21:21:36 +0200
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Hi,

After I couldn't get netfs_S_io_select working by overriding it for
some translator I am writing I noticed that it is cleared when when
the peropen structure is created.

I think O_NONBLOCK does not belong in OPENONLY_STATE_MODES.  First
because it is used after the node is opened.  Another reason is that
`HONORED_STATE_MODES' includes O_NONBLOCK (so it is valid).

Here is a patch to fix this problem.

Thanks,
Marco

2004-07-24  Marco Gerards  <metgerards@student.han.nl>

        * misc.h (OPENONLY_STATE_MODES): Remove O_NONBLOCK.


Index: misc.h
===================================================================
RCS file: /cvsroot/hurd/hurd/libnetfs/misc.h,v
retrieving revision 1.2
diff -u -p -r1.2 misc.h
--- misc.h      18 Dec 1995 19:02:52 -0000      1.2
+++ misc.h      24 Jul 2004 19:14:12 -0000
@@ -21,4 +21,4 @@
 #include <fcntl.h>
 
 /* Bits that are turned off after open */
-#define OPENONLY_STATE_MODES (O_CREAT|O_EXCL|O_NOLINK|O_NOTRANS|O_NONBLOCK)
+#define OPENONLY_STATE_MODES (O_CREAT|O_EXCL|O_NOLINK|O_NOTRANS)







reply via email to

[Prev in Thread] Current Thread [Next in Thread]