[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gnumach Cleanup Round 3 - Move printf.h and add panic declaration
From: |
Thomas Bushnell BSG |
Subject: |
Re: Gnumach Cleanup Round 3 - Move printf.h and add panic declaration |
Date: |
Thu, 09 Nov 2006 17:05:37 -0800 |
Why the change to add parentheses to printf.c:_doprnt? (If this is to
shut up a gcc warning, then it seems ok, I guess.)
We do not normally put comments on #include's saying why the file was
included for a couple reasons: it very quickly gets out of date, and it
doesn't really communicate anything very important. Such comments
belong in the ChangeLog entry, something like this:
* ddb/db_command.c: Include <kern/debug.h> for panic.
Thomas
signature.asc
Description: This is a digitally signed message part