[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: The patch of boot to open a virtual network interface
From: |
olafBuddenhagen |
Subject: |
Re: The patch of boot to open a virtual network interface |
Date: |
Sat, 9 Aug 2008 22:57:17 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
On Fri, Aug 08, 2008 at 07:06:29AM +0200, zhengda wrote:
> But the way to open the virtual network interface will be changed if
> the translator that helps open the device is created.
Indeed... So I guess we better don't commit it just yet :-)
> 2008-07-29 Zheng Da <zhengda1936@gmail.com>
>
> *boot/boot.c: add an option to open the virtual network interface
That's not a complete changelog...
> + if (err)
> + fprintf (stderr, "open_device returns %x, %s\n",
> + err, strerror (err));
Why don't you use error() here as well?
(Note that error() only exits when passed a non-0 status; otherwise, it
just prints a warning.)
Otherwise, the patch looks fine :-)
-antrik-