[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] Add a new exec_exec_file_name RPC
From: |
Carl Fredrik Hammar |
Subject: |
Re: [PATCH 1/3] Add a new exec_exec_file_name RPC |
Date: |
Tue, 1 Jun 2010 11:39:42 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Tue, Jun 01, 2010 at 03:52:59AM +0200, olafBuddenhagen@gmx.net wrote:
> On Mon, May 31, 2010 at 05:59:09PM +0200, Carl Fredrik Hammar wrote:
> > On Wed, May 26, 2010 at 12:15:37AM +0200, Emilio Pozuelo Monfort wrote:
>
> > > +kern_return_t
> > > +S_exec_exec_file_name (struct trivfs_protid *protid,
> > > + file_t file,
> > > + task_t oldtask,
> > > + int flags,
> > > + char *filename,
> > > + char *argv, mach_msg_type_number_t argvlen, boolean_t
> > > argv_copy,
> > > + char *envp, mach_msg_type_number_t envplen, boolean_t
> > > envp_copy,
> >
> > Break these two lines. Try to stick to less than 76 columns or less than
> > 80 if the reformatting changes lines that would otherwise be unaffected.
>
> Why 76?
It seems I'm missremembering. The number doesn't seem to be clearly
stated in the GNU Coding Standards, but indent --gnu uses 78. I'm of
the opinion that extra room makes it easier to add to lines in the future
so I try to keep lines shorter myself.
Regards,
Fredrik