[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
From: |
Carl Fredrik Hammar |
Subject: |
Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...) |
Date: |
Sat, 17 Jul 2010 12:32:22 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sat, Jul 17, 2010 at 12:25:48PM +0200, Carl Fredrik Hammar wrote:
> Hi,
>
> On Sat, Jul 17, 2010 at 11:37:34AM +0200, Emilio Pozuelo Monfort wrote:
> > + *(int*)*value = user->sock->pipe_class->sock_type;
> > + *value_len = sizeof (int);
> > + break;
> > + default:
> > + ret = ENOPROTOOPT;
> > + break;
> > + }
> > + break;
> > + default:
> > + ret = ENOPROTOOPT;
>
> Hmm, at this level it probably shouldn't be ENOPROTOOPT since it's not
> a protocol option, and since we it could still be a valid protocol level
> we can't return EINVAL. Sorry, this was only clear to me once you split
> the cases, guess it's back to EOPNOTSUPP here. :-)
Actually, scratch that. As long as it's a valid level it would still
be an unsupported option so just leave it as is.
Regards,
Fredrik
- [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Jérémie Koenig, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Carl Fredrik Hammar, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/17
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Samuel Thibault, 2010/07/17
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Carl Fredrik Hammar, 2010/07/17
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...),
Carl Fredrik Hammar <=
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/17
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Ludovic Courtès, 2010/07/17
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Carl Fredrik Hammar, 2010/07/17
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Ludovic Courtès, 2010/07/17
- RPC port classes (was: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)), olafBuddenhagen, 2010/07/30
- Prev by Date:
Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
- Next by Date:
Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
- Previous by thread:
Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
- Next by thread:
Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
- Index(es):