Re: [PATCH] Use the new __hurd_exec_file_name RPC

[Carl Fredrik Hammar]

Hi,

On Sat, Jul 17, 2010 at 02:07:19PM +0200, Guillem Jover wrote:
> On Fri, 2010-07-16 at 12:21:16 +0200, Emilio Pozuelo Monfort wrote:
> > And here goes the glibc one.
> 
> > diff --git a/hurd/hurd.h b/hurd/hurd.h
> > index 642ea43..a83c3fa 100644
> > --- a/hurd/hurd.h
> > +++ b/hurd/hurd.h
> > @@ -243,13 +243,21 @@ extern FILE *fopenport (io_t port, const char *mode);
> >  extern FILE *__fopenport (io_t port, const char *mode);
> > 
> > 
> > -/* Execute a file, replacing TASK's current program image.  */
> > +/* Deprecated: use _hurd_exec_file_name instead.  */
> > 
> >  extern error_t _hurd_exec (task_t task,
> >                        file_t file,
> >                        char *const argv[],
> >                        char *const envp[]);
> 
> I don't really know what's the policy around this in glibc, but maybe
> it would be appropriate, in addition to the comment, to mark it with
> __attribute_deprecated__ and to place it in the special warning section
> via link_warning()?

This is probably a good idea.  I added the suggestion to my review.

Regards,
  Fredrik