Re: [PATCH hurd/ext2fs] Sync pager before clearing MAY_CACHE flag

[Samuel Thibault]

Sergio López, le Thu 29 Sep 2011 11:44:40 +0200, a écrit :
> Sync'ing the pager before clearing that flag ensures that there aren't
> dirty pages in the object before its termination.

Do you mean that the writes will be completely avoided for objects which
have actually been removed?

> @@ -851,7 +851,10 @@ drop_pager_softrefs (struct node *node)
>    spin_unlock (&node_to_page_lock);
> 
>    if (MAY_CACHE && pager)
> -    pager_change_attributes (pager, 0, MEMORY_OBJECT_COPY_DELAY, 0);
> +    {
> +      pager_sync (pager, 1);

Won't using wait=1 reduce performance due to waiting for completion?

> +      pager_change_attributes (pager, 0, MEMORY_OBJECT_COPY_DELAY, 0);
> +    }
>    if (pager)
>      ports_port_deref (pager);
>  }

Samuel