[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finis
From: |
Pino Toscano |
Subject: |
Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished |
Date: |
Tue, 12 Feb 2013 23:52:09 +0100 |
User-agent: |
KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) |
Alle martedì 12 febbraio 2013, Svante Signell ha scritto:
> * change the FD_SETSIZE upper value check to larger than or equal
> from larger than.
> (from POSIX definition of select:
> http://pubs.opengroup.org/onlinepubs/009604499/functions/select.html
> )
It's
http://pubs.opengroup.org/onlinepubs/9699919799/functions/select.html
actually, and it says:
|[EINVAL]
| The nfds argument is less than 0 or greater than FD_SETSIZE.
and not "greater or equal than", so it allows FD_SETSIZE.
(And logically, if a fdset_t can contain at most FD_SETSIZE fd's, you
need to allow FD_SETSIZE as maximum number of fd's.)
Please remove this change, which is wrong.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, (continued)
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Svante Signell, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Svante Signell, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Richard Braun, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Svante Signell, 2013/02/13
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Richard Braun, 2013/02/13
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Svante Signell, 2013/02/13
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Richard Braun, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished,
Pino Toscano <=
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Svante Signell, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Pino Toscano, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Pino Toscano, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Svante Signell, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Pino Toscano, 2013/02/12
- Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Roland McGrath, 2013/02/12
- Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished, Samuel Thibault, 2013/02/12