Re: [PATCH 17/19] i386/i386at/kd.c: add forward declaration

[Samuel Thibault]

Marin Ramesa, le Wed 20 Nov 2013 21:38:05 +0100, a écrit :
> On 20.11.2013 21:29:06, Guillem Jover wrote:
> > On Wed, 2013-11-20 at 13:53:59 +0100, Marin Ramesa wrote:
> > > diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c
> > > index 3890c3d..a5dff3c 100644
> > > --- a/i386/i386at/kd.c
> > > +++ b/i386/i386at/kd.c
> > > @@ -965,6 +965,9 @@ boolean_t     up;
> > >   return(state);
> > >  }
> > >  
> > > +#if MACH_KDB
> > > +extern void kdb_kintr(void); /* forward */
> > > +#endif /* MACH_KDB */
> > 
> > Why not add it to a header file?
> 
> Is not used that much.

Still.  Putting it a header makes properly sure that the caller and the
callee agree on the convention.  The number of calls does not matter.

Samuel