Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

[Samuel Thibault]

Guillem Jover, le Wed 20 Nov 2013 23:50:59 +0100, a écrit :
> On Wed, 2013-11-20 at 21:48:14 +0100, Samuel Thibault wrote:
> > Guillem Jover, le Wed 20 Nov 2013 21:09:08 +0100, a écrit :
> > > >  #ifdef SOFTWARE_SSTEP
> > > > +           db_addr_t brpc;
> > > >             /* Account for instructions in delay slots */
> > > >             brpc = next_instr_address(pc, 1, task);
> > > >             if ((brpc != pc) && (inst_branch(ins) || inst_call(ins))) {
> > > 
> > > This adds intermixing of statements and declarations.
> > 
> > What kind of problem do you expect?  C99 is almost 15 years old now.
> 
> Oh, no compiler problem; sorry, I should have been explicit, I was
> thinking about this possibly not being in line with the current
> coding style.

Ah, right, we probably don't use that yet indeed. So it'd mean adding a
{} block around the code (or conditionally comment the variable
declaration at its original place, but I usually find it bad looking).

Samuel