Re: Trying to solve file lock problem with /etc/sudoers

[Samuel Thibault]

Hello,

Peter Baumgarten, le Tue 11 Mar 2014 16:04:04 -0500, a écrit :
> I looked through the
> bugzilla list and did not know which bug I should tackle, but I was
> annoyed that I could not shutdown as a normal user because of the visudo
> problem, so I thought why not tackle that bug?

That's exactly the way I recommend: tackle a bug you actually care for
:)

Concerning that precise bug, I believe it should be quite easy:
debian/patches/use-flock-on-hurd.diff is really supposed to make
./configure switch to flock instead of the known-not-to-work lockf,
and that doesn't seem to be having effect: the buildd log shows that
./configure still believes lockf is available. You should check what
happens in the configure script, and fix the use-flock-on-hurd.diff
patch accordingly.  The second part would be fixing lockf in glibc
in the simple case used by sudo, which is locking the whole file.
It should be a matter of calling some lseek() inside fcntl() in
glibc/sysdeps/mach/hurd/fcntl.c and check whether it happens to be 0,
instead of just returning errno=ENOTSUP in the SEEK_CUR case.

Samuel