Re: [PATCH 2/5] libshouldbeinlibc: fix dead initialization in fmt_named_interval

[Samuel Thibault]

Justus Winter, le Mon 16 Jun 2014 19:49:26 +0200, a écrit :
> Found using the Clang Static Analyzer.
> 
> * libshouldbeinlibc/timefmt.c (fmt_named_interval): Fix dead
> initialization.

Ack.

> ---
>  libshouldbeinlibc/timefmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libshouldbeinlibc/timefmt.c b/libshouldbeinlibc/timefmt.c
> index a28f58b..cef72e0 100644
> --- a/libshouldbeinlibc/timefmt.c
> +++ b/libshouldbeinlibc/timefmt.c
> @@ -105,7 +105,7 @@ fmt_named_interval (struct timeval *tv, size_t width,
>      {{0, 1},       {0, 1},     {0, 0},    {" microsecond", "us", 0 }},
>      {{0, 0} }
>    };
> -  struct tscale *ts = time_scales;
> +  struct tscale *ts;
>  
>    if (width <= 0 || width >= buf_len)
>      width = buf_len - 1;
> -- 
> 2.0.0
> 

-- 
Samuel
As usual, this being a 1.3.x release, I haven't even compiled this
kernel yet.  So if it works, you should be doubly impressed.
(Linus Torvalds, announcing kernel 1.3.3 on the linux-kernel mailing list.)