[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH,Hurd] Fix hang on fork
From: |
Roland McGrath |
Subject: |
Re: [PATCH,Hurd] Fix hang on fork |
Date: |
Thu, 28 Aug 2014 13:04:14 -0700 (PDT) |
> This is what I had put, is some information still missing?
Oh, was that in the message? I must have missed it because I didn't see a
ChangeLog header.
> * sysdeps/mach/hurd/fork.c (__fork): Lock SS->lock around __proc_dostop()
> call.
Don't use () as if it were part of a function name. Otherwise that is just
right (though it's ok to omit " (__fork)" in a libc file whose file name
matches the function).
> + /* Keep our SS locked while stopping other threads, so they don't get a
> + chance to be having it locked in the copied space. */
I didn't bother to say that this sentence is rather awkward to a native
English speaker: s/to be having it locked/to have it locked/.
The formatting is now correct, so you can go ahead and commit.
Thanks,
Roland