[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-inetutils] [patch] syslogd leaks FILE variables when returning from
From: |
Guillem Jover |
Subject: |
[bug-inetutils] [patch] syslogd leaks FILE variables when returning from init |
Date: |
Sat, 21 Oct 2006 15:23:39 +0300 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hi,
As I told Alfred some time ago, I was going to request access to the
Coverity scan reports. I did, and have been reviewing them. So I'll be
sending patches fixing the issues there. I checked the servers and
common libraries first. There does not seem to be anything fatal for
now, though.
2006-10-21 Guillem Jover <address@hidden>
* syslogd/init.c (init): Free cf before returning due to not enough
memory errors.
Index: syslogd/syslogd.c
===================================================================
RCS file: /sources/inetutils/inetutils/syslogd/syslogd.c,v
retrieving revision 1.73
diff -u -r1.73 syslogd.c
--- syslogd/syslogd.c 12 Oct 2006 09:56:58 -0000 1.73
+++ syslogd/syslogd.c 21 Oct 2006 12:19:26 -0000
@@ -1656,6 +1656,7 @@
{
/* There is no graceful recovery here. */
dbg_printf ("cannot allocate space for configuration\n");
+ fclose (cf);
return;
}
cline = cbuf;
@@ -1695,6 +1696,7 @@
{
/* Sigh ... */
dbg_printf ("cannot allocate space configuration\n");
+ fclose (cf);
free (cbuf);
return;
}
- [bug-inetutils] [patch] syslogd leaks FILE variables when returning from init,
Guillem Jover <=