[bug-inetutils] Anomalies in the code

[Debarshi Ray]

Over the last few days I have come across certain anomalies in the
code and since I am not familiar with those portions, I decided to
throw them one by one to the list and let others ideate on how to
rectify them.

So here is one such example which causes a:
"warning: 'return' with no value, in function returning non-void"

telnet/commands.c:

unsigned char *
env_default (int init, int welldefined)
{
  static struct env_lst *nep = NULL;

  if (init)
    {
      nep = &envlisthead;
      return;
    }
  if (nep)
    {
      nep = nep->next;
      while (nep != NULL)
        {
          if (nep->export && (nep->welldefined == welldefined))
            return (nep->var);
        }
    }
  return (NULL);
}

Any ideas?

Happy hacking,
Debarshi
-- 
"From what we get, we can make a living; what we give, however, makes a life."
 -- Arthur Ashe