Re: [bug-inetutils] ping vs ping6 vs libicmp

[Alfred M. Szmidt]

   As I had mentioned in another thread, I am keen to factor out the
   common code between ping and ping6.  This is necessary partly to
   fix some bugs in ping6, but would be most helpful while
   implementing new features and fixing bugs.  Now I find that we have
   libicmp/ and a bunch of ping_*.[ch] files in ping/.  Since libping
   is built as a static library, I was wondering whether we should
   shift all the common portions into libicmp and keep only the
   ping/ping6 specific code in the ping directory.  Or should it be
   something else?

libicmp should contain ICMP specific cruft.  What is the problem of
using say ping_common.[ch] and share that between ping{6,} for ping
specific code?